-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report throw
calls appropriately
#17
Conversation
So CI reveals out this native implementation can report (potentially too many) false positives. julia> @profile_call sin(1)
═════ 1 possible error found ═════
┌ @ special/trig.jl:53 Base.Math.sin(Base.Math.float(x::Int64)::Float64)
│┌ @ special/trig.jl:39 Base.Math.sin_domain_error(x::Float64)
││┌ @ special/trig.jl:28 unreachable
│││ will throw: Base.Math.throw(Base.Math.DomainError(x::Float64, "sin(x) is only defined for finite x.")::Any)
││└──────────────────────
Float64 These lines of code suppress EDIT: simple false positives are fixed by simple inter-frame analysis |
5469973
to
8c9898f
Compare
8c9898f
to
4c37d86
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 65.77% 68.21% +2.43%
==========================================
Files 10 10
Lines 561 604 +43
==========================================
+ Hits 369 412 +43
Misses 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.